jetbrains: reformat longDescriptions, adjust some wording#478464
Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom Jan 9, 2026
Merged
jetbrains: reformat longDescriptions, adjust some wording#478464MattSturgeon merged 1 commit intoNixOS:masterfrom
MattSturgeon merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
requested review from
GenericNerdyUsername,
dritter,
gytis-ivaskevicius,
jamesward,
leona-ya,
thiagokokada and
tymscar
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
|
Not sure why, but we're seeing: Changed packages (9)
I would've expected the |
Member
Author
|
This is because of some other minor typos I fixed, e.g. for -description = "... Jetbrains ...";
+description = "... JetBrains ..."; |
MattSturgeon
approved these changes
Jan 9, 2026
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #475183
My original preferred idea was to not use the meta attributes for desktop files anymore and just patch the desktop files provided by JetBrains... but turns out there are none!
So I figured it's easiest if we just keep using the meta attributes. I adjusted the comments a bit, improved the formatting and changed some descriptions to be a bit shorter (but I think the rest is up to the individual maintainers).
I also made sure the longDescription is trimmed before used in the desktop file to avoid unnecessary rebuilds on whitespace changes.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.